Add Extent::concat #1419
Closed
Add Extent::concat #1419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Addressing Github issue: https://fburl.com/ns9ekdb7. Add a method to Extent so it can concatenate another Extent. This method will check duplicate labels and return error if the sizes are conflicting, otherwise it will merge duplicate labels in the new Extent. 2. Add tests for several cases of concatenation, including overlapping labels with or without conflicting label sizes. 3. Simplify an manual concatenation in host_mesh by calling this new method. Differential Revision: [D83869447](https://our.internmc.facebook.com/intern/diff/D83869447/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83869447/)! [ghstack-poisoned]
shuhuayu
pushed a commit
that referenced
this pull request
Oct 3, 2025
1. Addressing Github issue: https://fburl.com/ns9ekdb7. Add a method to Extent so it can concatenate another Extent. This method will check duplicate labels and return error if the sizes are conflicting, otherwise it will merge duplicate labels in the new Extent. 2. Add tests for several cases of concatenation, including overlapping labels with or without conflicting label sizes. 3. Simplify an manual concatenation in host_mesh by calling this new method. Differential Revision: [D83869447](https://our.internmc.facebook.com/intern/diff/D83869447/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83869447/)! ghstack-source-id: 313976776 Pull Request resolved: #1419
meta-cla
bot
added
the
CLA Signed
1. Addressing Github issue: https://fburl.com/ns9ekdb7. Add a method to Extent so it can concatenate another Extent. This method will check duplicate labels and return error if the sizes are conflicting, otherwise it will merge duplicate labels in the new Extent. 2. Add tests for several cases of concatenation, including overlapping labels with or without conflicting label sizes. 3. Simplify an manual concatenation in host_mesh by calling this new method. Differential Revision: [D83869447](https://our.internmc.facebook.com/intern/diff/D83869447/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83869447/)! [ghstack-poisoned]
shuhuayu
pushed a commit
that referenced
this pull request
Oct 3, 2025
Pull Request resolved: #1419 1. Addressing Github issue: https://fburl.com/ns9ekdb7. Add Extent concatenation method `Extent::concat` with duplicate label validation. Returns `ExtentError::OverlappingLabel` when duplicate labels are detected. 2. Add tests for several cases of concatenation, including cases with overlapping labels. 3. Simplify an manual concatenation in host_mesh by calling this new method. ghstack-source-id: 314027208 @exported-using-ghexport Differential Revision: [D83869447](https://our.internmc.facebook.com/intern/diff/D83869447/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83869447/)!
1. Addressing Github issue: https://fburl.com/ns9ekdb7. Add a method to Extent so it can concatenate another Extent. This method will check duplicate labels and return error if the sizes are conflicting, otherwise it will merge duplicate labels in the new Extent. 2. Add tests for several cases of concatenation, including overlapping labels with or without conflicting label sizes. 3. Simplify an manual concatenation in host_mesh by calling this new method. Differential Revision: [D83869447](https://our.internmc.facebook.com/intern/diff/D83869447/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83869447/)! [ghstack-poisoned]
shuhuayu
pushed a commit
that referenced
this pull request
Oct 4, 2025
Pull Request resolved: #1419 1. Addressing Github issue: https://fburl.com/ns9ekdb7. Add Extent concatenation method `Extent::concat` with duplicate label validation. Returns `ExtentError::OverlappingLabel` when duplicate labels are detected. 2. Add tests for several cases of concatenation, including cases with overlapping labels. 3. Simplify an manual concatenation in `host_mesh.rs` by calling 'Extent::concat`. ghstack-source-id: 314031261 @exported-using-ghexport Differential Revision: [D83869447](https://our.internmc.facebook.com/intern/diff/D83869447/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83869447/)!
1. Addressing Github issue: https://fburl.com/ns9ekdb7. Add a method to Extent so it can concatenate another Extent. This method will check duplicate labels and return error if the sizes are conflicting, otherwise it will merge duplicate labels in the new Extent. 2. Add tests for several cases of concatenation, including overlapping labels with or without conflicting label sizes. 3. Simplify an manual concatenation in host_mesh by calling this new method. Differential Revision: [D83869447](https://our.internmc.facebook.com/intern/diff/D83869447/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83869447/)! [ghstack-poisoned]
shuhuayu
pushed a commit
that referenced
this pull request
Oct 4, 2025
Pull Request resolved: #1419 1. Addressing Github issue: https://fburl.com/ns9ekdb7. Add Extent concatenation method `Extent::concat` with duplicate label validation. Returns `ExtentError::OverlappingLabel` when duplicate labels are detected. 2. Add tests for several cases of concatenation, including cases with overlapping labels. 3. Simplify an manual concatenation in `host_mesh.rs` by calling 'Extent::concat`. ghstack-source-id: 314037827 @exported-using-ghexport Differential Revision: [D83869447](https://our.internmc.facebook.com/intern/diff/D83869447/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83869447/)!
1. Addressing Github issue: https://fburl.com/ns9ekdb7. Add a method to Extent so it can concatenate another Extent. This method will check duplicate labels and return error if the sizes are conflicting, otherwise it will merge duplicate labels in the new Extent. 2. Add tests for several cases of concatenation, including overlapping labels with or without conflicting label sizes. 3. Simplify an manual concatenation in host_mesh by calling this new method. Differential Revision: [D83869447](https://our.internmc.facebook.com/intern/diff/D83869447/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83869447/)! [ghstack-poisoned]
shuhuayu
pushed a commit
that referenced
this pull request
Oct 4, 2025
Pull Request resolved: #1419 1. Addressing Github issue: https://fburl.com/ns9ekdb7. Add Extent concatenation method `Extent::concat` with duplicate label validation. Returns `ExtentError::OverlappingLabel` when duplicate labels are detected. 2. Add tests for several cases of concatenation, including cases with overlapping labels. 3. Simplify an manual concatenation in `host_mesh.rs` by calling 'Extent::concat`. ghstack-source-id: 314041614 @exported-using-ghexport Differential Revision: [D83869447](https://our.internmc.facebook.com/intern/diff/D83869447/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83869447/)!
1. Addressing Github issue: https://fburl.com/ns9ekdb7. Add a method to Extent so it can concatenate another Extent. This method will check duplicate labels and return error if the sizes are conflicting, otherwise it will merge duplicate labels in the new Extent. 2. Add tests for several cases of concatenation, including overlapping labels with or without conflicting label sizes. 3. Simplify an manual concatenation in host_mesh by calling this new method. Differential Revision: [D83869447](https://our.internmc.facebook.com/intern/diff/D83869447/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83869447/)! [ghstack-poisoned]
shuhuayu
pushed a commit
that referenced
this pull request
Oct 6, 2025
Pull Request resolved: #1419 1. Addressing Github issue: https://fburl.com/ns9ekdb7. Add Extent concatenation method `Extent::concat` with duplicate label validation. Returns `ExtentError::OverlappingLabel` when duplicate labels are detected. 2. Add tests for several cases of concatenation, including cases with overlapping labels. 3. Simplify an manual concatenation in `host_mesh.rs` by calling 'Extent::concat`. ghstack-source-id: 314332973 @exported-using-ghexport Differential Revision: [D83869447](https://our.internmc.facebook.com/intern/diff/D83869447/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83869447/)!
|
This pull request has been merged in 24a25c6. |
AlirezaShamsoshoara
pushed a commit
to AlirezaShamsoshoara/monarch
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: meta-pytorch#1419 1. Addressing Github issue: https://fburl.com/ns9ekdb7. Add Extent concatenation method `Extent::concat` with duplicate label validation. Returns `ExtentError::OverlappingLabel` when duplicate labels are detected. 2. Add tests for several cases of concatenation, including cases with overlapping labels. 3. Simplify an manual concatenation in `host_mesh.rs` by calling 'Extent::concat`. ghstack-source-id: 314332973 exported-using-ghexport Reviewed By: shayne-fletcher Differential Revision: D83869447 fbshipit-source-id: 1dd83b5f8705287e2e3b659eee815c967524b9c8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Addressing Github issue: https://fburl.com/ns9ekdb7. Add a method to Extent so it can concatenate another Extent. This method will check duplicate labels and return error if the sizes are conflicting, otherwise it will merge duplicate labels in the new Extent.
Add tests for several cases of concatenation, including overlapping labels with or without conflicting label sizes.
Simplify an manual concatenation in host_mesh by calling this new method.
Differential Revision: D83869447
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!